New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in capability to supply user
and password
with mongodb
#1795
Conversation
This is the previous PR: #1788
Docs - Add slack match_event params
…espond method - Added in kwargs to the respond method - Set response_type variable based on kwarg with same name - Set response_type based on value passed in for the case where response_event is a str
Add ephemeral response_type to the Slack connector InteractiveAction respond method
Some mongodb environments require username and password to be supplied in order to properly connect. This change allows this while not breaking current functionality where this does not need to be provided.
…Action respond method" This reverts commit 193133a.
Codecov Report
@@ Coverage Diff @@
## master #1795 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 77 77
Lines 4630 4634 +4
=======================================
+ Hits 4597 4601 +4
Misses 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sane.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you so much.
Could I ask you to also update the config schema?
CONFIG_SCHEMA = {"host": str, "port": Any(int, str), "database": str} |
@jacobtomlinson Done! |
Awesome work thanks @ajitdsa |
…oid#1795) * Add documentation for the matchers for match_event from previous PR. This is the previous PR: opsdroid#1788 * Add ephemeral response_type to the Slack connector IneractiveAction respond method - Added in kwargs to the respond method - Set response_type variable based on kwarg with same name - Set response_type based on value passed in for the case where response_event is a str * Add in capability to supply user and password with mongodb Some mongodb environments require username and password to be supplied in order to properly connect. This change allows this while not breaking current functionality where this does not need to be provided. * Add documentation to support user and password functionality for mongodb * do not use user/password if they are not supplied * Add test for user/password mongo connection functionality * Revert "Add ephemeral response_type to the Slack connector IneractiveAction respond method" This reverts commit 193133a. * Format using black * Fixed test * Update CONFIG_SCHEMA
Description
Some mongodb environments require
user
andpassword
to be supplied in order to properly connect. This change allows this while not breaking current functionality where this does not need to be provided.Add documentation to support
user
andpassword
functionality for mongodb.Status
READY
Type of change
How Has This Been Tested?
user
andpassword
when initializing the databaseChecklist: