Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Push event for GitHub connector #1821

Merged
merged 1 commit into from Aug 16, 2021

Conversation

ajitdsa
Copy link
Contributor

@ajitdsa ajitdsa commented Aug 14, 2021

Description

Adding an event that triggers when a user pushes commits to a branch in Github.

Status

READY

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Documentation (fix or adds documentation)

How Has This Been Tested?

Added a test in test_connector_github.py for this functionality. Also tested manually with my own github account.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #1821 (0fe08ab) into master (c6643da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1821   +/-   ##
=======================================
  Coverage   99.30%   99.30%           
=======================================
  Files          80       80           
  Lines        4762     4772   +10     
=======================================
+ Hits         4729     4739   +10     
  Misses         33       33           
Impacted Files Coverage Δ
opsdroid/connector/github/__init__.py 100.00% <100.00%> (ø)
opsdroid/connector/github/events.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6643da...0fe08ab. Read the comment docs.

@jacobtomlinson jacobtomlinson merged commit c21462c into opsdroid:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants