Get connector name from configuration,

[FabioRosado]

Description

Fixes #1844

This PR replaces all the hardcoded names with self.config.get("name", <connector name>) to allow users to specify the name of the connector. It also adds a section in our connectors page telling users how to use two connectors in the same opsdroid instance since I had to search for a while about how to do this until I remembered that Jacob had mentioned something like that in one of our channels 😆

I'm also using the import organize imports setting in VSCode so some imports were automatically changed. Let me know if you would rather me revert these changes.

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

• New feature (non-breaking change which adds functionality)
• Documentation (fix or adds documentation)

How Has This Been Tested?

• Created two slack connectors, both worked

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[codecov]

Codecov Report

Merging #1845 (829a4fb) into master (9a48364) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1845   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files          80       80           
  Lines        4834     4834           
=======================================
  Hits         4802     4802           
  Misses         32       32           

Impacted Files	Coverage Δ
opsdroid/connector/facebook/__init__.py	100.00% <100.00%> (ø)
opsdroid/connector/github/__init__.py	100.00% <100.00%> (ø)
opsdroid/connector/gitter/connector.py	100.00% <100.00%> (ø)
opsdroid/connector/matrix/connector.py	98.51% <100.00%> (ø)
opsdroid/connector/mattermost/__init__.py	100.00% <100.00%> (ø)
opsdroid/connector/rocketchat/__init__.py	100.00% <100.00%> (ø)
opsdroid/connector/shell/__init__.py	100.00% <100.00%> (ø)
opsdroid/connector/slack/connector.py	100.00% <100.00%> (ø)
opsdroid/connector/teams/teams.py	100.00% <100.00%> (ø)
opsdroid/connector/telegram/__init__.py	100.00% <100.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a48364...829a4fb. Read the comment docs.

[cognifloyd]

I love the naming change.

The imports stuff highlights some inconsistencies in our imports sorting. Maybe we should add isort to or pre-commit-hook.

[Cadair]

Wait we didn't do this already?? 🤣

I would suggest reverting the import ordering stuff and then opening a new PR using isort / pre-commit or something we can all run?

[FabioRosado]

Sure and as I mentioned in the PR, they got sorted automatically with VSCode settings

[FabioRosado]

Wait we didn't do this already?? rofl

I would suggest reverting the import ordering stuff and then opening a new PR using isort / pre-commit or something we can all run?

Yeah we don't but it seems that our version of black and isort are fighting in the pre-commit haha

[Cadair]

Yeah we don't but it seems that our version of black and isort are fighting in the pre-commit haha

There's a new(ish) flag in isort to be black compatible.

[jacobtomlinson]

We use black and isort in Dask. Seem to play nicely together these days.