Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing KeyErrors on messages without text #1923

Merged
merged 1 commit into from May 14, 2022
Merged

Fixing KeyErrors on messages without text #1923

merged 1 commit into from May 14, 2022

Conversation

D3N14L
Copy link
Contributor

@D3N14L D3N14L commented May 14, 2022

This may occur if messages consist only of media elements. A message
that consists just a gif for example

Fixes #1909

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • not tested

Checklist:

  • I have performed a self-review of my own code
  • [n/a] I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This may occur if messages consist only of media elements. A message
that consists just a gif for example
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #1923 (74709e6) into master (2f2034a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1923   +/-   ##
=======================================
  Coverage   99.33%   99.33%           
=======================================
  Files          83       83           
  Lines        5114     5114           
=======================================
  Hits         5080     5080           
  Misses         34       34           
Impacted Files Coverage Δ
opsdroid/connector/telegram/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2034a...74709e6. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@FabioRosado FabioRosado merged commit a4beecc into opsdroid:master May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegram connector stops working after a reply with just a GIF
2 participants