Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto mode for pytest #1942

Merged
merged 1 commit into from Jul 28, 2022
Merged

Conversation

chillipeper
Copy link
Contributor

@chillipeper chillipeper commented Jul 28, 2022

Description

Starting from pytest-asyncio>=0.17, three modes are provided: auto,
strict, and legacy. Starting from pytest-asyncio>=0.19 the strict
mode is the default.

This is causing tests to fail when the latest version pytest-asyncio is installed

https://github.com/pytest-dev/pytest-asyncio/releases/tag/v0.19.0

Also removing the duplicate entry of dialogflow which is also making the tests fail

Status

READY

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Yes tests pass now

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #1942 (b902e31) into master (299cd55) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1942   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          83       83           
  Lines        5354     5357    +3     
=======================================
+ Hits         5321     5324    +3     
  Misses         33       33           
Impacted Files Coverage Δ
opsdroid/web.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912e3bc...b902e31. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've been thinking about doing this for a long time haha

@FabioRosado FabioRosado merged commit a8ec6d1 into opsdroid:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants