Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python and Alpine base image #1979

Merged
merged 1 commit into from Feb 1, 2023

Conversation

pwillis-eiq
Copy link
Contributor

@pwillis-eiq pwillis-eiq commented Jan 20, 2023

Description

Fixes security holes in Python and Alpine base image and updates base before EOL.

  • From Python 3.9.6 to 3.9.16, there are many security holes patched as well as bugfixes.
  • Alpine 3.16 is the previous stable release (current is 3.17), but the latest stable release introduces some major changes, such as OpenSSL 3.0, so more testing is suggested. Using 3.16 patches some security holes, and moves up the timeline of support, as 3.14 will reach EOL later this year.

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Built container locally
  • Ran opsdroid from new container (Slack connector, ping skill)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Use the latest stable Python 3.9 branch, and update the Alpine base image to 3.16

- From Python 3.9.6 to 3.9.16, there are many security holes patched as well as bugfixes.
- Alpine 3.16 is the previous stable release (3.17), but the latest stable release introduces some major changes, such as OpenSSL 3.0, so more testing is suggested. Using 3.16 patches some security holes, and moves up the timeline of support, as 3.14 will reach EOL later this year.
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 99.38% // Head: 99.38% // No change to project coverage 👍

Coverage data is based on head (d485ad7) compared to base (7969a1a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1979   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          83       83           
  Lines        5366     5366           
=======================================
  Hits         5333     5333           
  Misses         33       33           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@FabioRosado FabioRosado merged commit ccacc71 into opsdroid:master Feb 1, 2023
@pwillis-eiq pwillis-eiq deleted the patch-1 branch February 1, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants