New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timeout on matrix connection and related errors handling #1984
add timeout on matrix connection and related errors handling #1984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello thank you for working on this fix and opening the PR!
I've added some comments but they are non blocking for this PR so I'm approving it
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1984 +/- ##
==========================================
- Coverage 99.16% 99.09% -0.08%
==========================================
Files 83 83
Lines 5395 5400 +5
==========================================
+ Hits 5350 5351 +1
- Misses 45 49 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I believe it's ready to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is incomplete, you don't seem to use the timeout or the retry?
update error message Co-authored-by: Stuart Mumford <stuart@cadair.com>
Sorry we never got this over the line. Given the age of this PR I'm going to close it out. |
Description
Fixes #1750
Status
READY
Type of change
How Has This Been Tested?
Checklist: