New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3.11 job to tox and github actions config #1999
base: main
Are you sure you want to change the base?
Conversation
50f9ae5
to
4a1efda
Compare
- /connector/slack/connector.py was failing every Git CI, included a try except to fix this
Not sure why the tests are failing despite many of the fails and errors weren't even relate to the changes i made for python 3.11 |
@Alex-Wengg I see that this change includes the replacement of the I am curious if there's any reason why both are included under the same PR. As the library replacement, is quite a large change, I think it might bring some challenges to who ever is reviewing those. My 2 cents here is that it would be cleaner if we treat them as 2 separate changes, if that's even possible of course. |
I was trying to debug the issue as to why the Github Action tests kept failing for this specific repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this took so long to review. Main CI is passing now so I'm trying to get this up to date.
Description
First iteration to help migrate python3.8 -> latest python3.11