Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3.11 job to tox and github actions config #1999

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Alex-Wengg
Copy link

@Alex-Wengg Alex-Wengg commented Jun 22, 2023

Description

First iteration to help migrate python3.8 -> latest python3.11

@Alex-Wengg Alex-Wengg changed the title Added 3.11 job to tox and github actions config (#1987) Added 3.11 job to tox and github actions config Jun 22, 2023
@Alex-Wengg Alex-Wengg force-pushed the py311_tox branch 6 times, most recently from 50f9ae5 to 4a1efda Compare June 22, 2023 20:56
- /connector/slack/connector.py was failing every Git CI, included a try
  except to fix this
@Alex-Wengg
Copy link
Author

Not sure why the tests are failing despite many of the fails and errors weren't even relate to the changes i made for python 3.11

@chillipeper
Copy link
Contributor

@Alex-Wengg I see that this change includes the replacement of the asynctest.mock library with the unittest.mock library.

I am curious if there's any reason why both are included under the same PR.

As the library replacement, is quite a large change, I think it might bring some challenges to who ever is reviewing those. My 2 cents here is that it would be cleaner if we treat them as 2 separate changes, if that's even possible of course.

@Alex-Wengg
Copy link
Author

@Alex-Wengg I see that this change includes the replacement of the asynctest.mock library with the unittest.mock library.

I am curious if there's any reason why both are included under the same PR.

As the library replacement, is quite a large change, I think it might bring some challenges to who ever is reviewing those. My 2 cents here is that it would be cleaner if we treat them as 2 separate changes, if that's even possible of course.

I was trying to debug the issue as to why the Github Action tests kept failing for this specific repo

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long to review. Main CI is passing now so I'm trying to get this up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants