Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure web server to use TLS 1.2 protocol for ssl_context #2014

Merged

Conversation

spinits4
Copy link
Contributor

Description

Upgrades tls protocol for web server ssl_context from deprecated TLS v1.0 to TLS v1.2

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Created a web server instance using TLS v1.2 which correctly worked in opposition to tls v1.0 which was giving "curl: (35) error:1425F102:SSL routines:ssl_choose_client_version:unsupported protocol"

Checklist:

  • [/] I have performed a self-review of my own code
  • [/] I have made corresponding changes to the documentation (if applicable)
  • [/] I have added tests that prove my fix is effective or that my feature works
  • [/] New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41246da) 99.16% compared to head (e9223ed) 99.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2014   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          83       83           
  Lines        5395     5395           
=======================================
  Hits         5350     5350           
  Misses         45       45           
Files Coverage Δ
opsdroid/web.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chillipeper chillipeper mentioned this pull request Oct 23, 2023
4 tasks
@chillipeper
Copy link
Contributor

@jacobtomlinson @FabioRosado any chance this could be looked at?

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change.

@jacobtomlinson jacobtomlinson merged commit e2ffb0c into opsdroid:master Oct 31, 2023
13 of 17 checks passed
@jacobtomlinson jacobtomlinson added bug security Pull requests that address a security vulnerability labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants