fix(matrix/spec): filter_id is a string, not an integer
#2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source: https://spec.matrix.org/v1.9/client-server-api/#post_matrixclientv3useruseridfilter This is explicitly a string in the specification. Signed-off-by: Raito Bezarius <masterancpp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Source: https://spec.matrix.org/v1.9/client-server-api/#post_matrixclientv3useruseridfilter
This is explicitly a string in the specification.
This fixes compatibility with spec compliant servers like conduit.rs and not implementation-defined ones like Synapse.
Credit to @CobaltCause for accompanying me on this journey.
Status
READY
Type of change
How Has This Been Tested?
Checklist: