Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Getting Started Info (Issue #215) #231

Merged
merged 34 commits into from
Sep 29, 2017

Conversation

FabioRosado
Copy link
Member

Logged some important links and added a quick text about customising opsdroid instance in configuration.yaml. I didn't add too much text because the user probably doesn't want to be spammed with a wall of text.

Let me know if this is okay or if you'd rather have something else logged in the console.

@coveralls
Copy link

coveralls commented Sep 26, 2017

Coverage Status

Coverage increased (+0.04%) to 95.195% when pulling 8dc3956 on FabioRosado:master into 84206f9 on opsdroid:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 95.195% when pulling 8dc3956 on FabioRosado:master into 84206f9 on opsdroid:master.

@jacobtomlinson
Copy link
Member

This is great thanks!

I like the idea of showing this on every run, but it might be nice to allow people to hide it. Could you add an option to the config along the lines of show_welcome_message which defaults to true, but if it's set to false then it needs to be hidden.

This probably affects the place where you are logging this, as it will need to be done after the config is loaded.

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage decreased (-1.1%) to 94.021% when pulling 1bbf4b0 on FabioRosado:master into 84206f9 on opsdroid:master.

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage decreased (-1.1%) to 94.021% when pulling aa0ef77 on FabioRosado:master into 84206f9 on opsdroid:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 94.021% when pulling 4d9d717 on FabioRosado:master into 84206f9 on opsdroid:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.1%) to 94.021% when pulling 4d9d717 on FabioRosado:master into 84206f9 on opsdroid:master.

@coveralls
Copy link

coveralls commented Sep 27, 2017

Coverage Status

Coverage decreased (-1.1%) to 94.021% when pulling 1f73534 on FabioRosado:master into 84206f9 on opsdroid:master.

@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage decreased (-0.08%) to 95.089% when pulling 53ab307 on FabioRosado:master into 2e58b87 on opsdroid:master.

@jacobtomlinson
Copy link
Member

Awesome work!

@jacobtomlinson jacobtomlinson merged commit 4c1337e into opsdroid:master Sep 29, 2017
FabioRosado added a commit to FabioRosado/opsdroid that referenced this pull request Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants