Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recast.AI parser #343

Merged
merged 1 commit into from Nov 20, 2017
Merged

Conversation

FabioRosado
Copy link
Member

Description

Adds Recast.AI parser/matcher to opsdroid. I've decided to go with interacting with the API instead of using the python sdk since it doesn't use asyncio.

Recast.AI offers different endpoints to interact with the API. At the moment only the /request endpoint is used. From the documentation: "This endpoint retrieves all metadata and intents from a sentence."

Fixes #337

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation (fix or adds documentation)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Local Unit Tests - All Green
  • Travis CI - All Green
  • Tested with the skills: weather, hello, help - All ok.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.407% when pulling 9f4fc0f on FabioRosado:recastai into 7993215 on opsdroid:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+0.1%) to 97.407% when pulling 9f4fc0f on FabioRosado:recastai into 7993215 on opsdroid:master.

@codecov
Copy link

codecov bot commented Nov 15, 2017

Codecov Report

Merging #343 into master will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #343      +/-   ##
=========================================
+ Coverage   97.25%   97.4%   +0.14%     
=========================================
  Files          17      18       +1     
  Lines         839     887      +48     
=========================================
+ Hits          816     864      +48     
  Misses         23      23
Impacted Files Coverage Δ
opsdroid/matchers.py 100% <100%> (ø) ⬆️
opsdroid/core.py 98.26% <100%> (+0.05%) ⬆️
opsdroid/parsers/recastai.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f795e3...65873e6. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 97.407% when pulling 4bae561 on FabioRosado:recastai into 7993215 on opsdroid:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+0.1%) to 97.407% when pulling 4bae561 on FabioRosado:recastai into 7993215 on opsdroid:master.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome work! Can you just check your documentation over.

@@ -0,0 +1,115 @@
# wit.ai Matcher
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say recast.ai

  - Remove commented out code
  - Fix documentation
@FabioRosado
Copy link
Member Author

Ooops missed those two mentions of wit.ai, apologies for it. It should be okay now 👍

@coveralls
Copy link

coveralls commented Nov 18, 2017

Coverage Status

Coverage increased (+0.1%) to 97.407% when pulling 65873e6 on FabioRosado:recastai into 3f795e3 on opsdroid:master.

@jacobtomlinson
Copy link
Member

Thanks!

@jacobtomlinson jacobtomlinson merged commit 4638f5e into opsdroid:master Nov 20, 2017
@FabioRosado FabioRosado deleted the recastai branch November 20, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants