-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asyncio docs and extend YouTube video text #478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 18 18
Lines 1092 1092
======================================
Hits 1091 1091
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
Please remove the reference to @asyncio.coroutine
as it has been replaced by async def
. We do not need to mention the old way of doing things.
will do |
That's great! Also can you mention the |
done. anything else? |
Nope this looks good, I'll merge it now. |
Ping me your address via DM on Twitter or Gitter and I'll post you some opsdroid stickers! |
Description
Added references to asynchronous functions, changed description of video series and added a link to the video series in the "create your own skill" section. Basically worked on issue #437
Fixes #437
Status
READY
Type of change
Checklist: