Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asyncio docs and extend YouTube video text #478

Merged
merged 9 commits into from
Mar 5, 2018
Merged

Add asyncio docs and extend YouTube video text #478

merged 9 commits into from
Mar 5, 2018

Conversation

TarunRKaushik
Copy link
Contributor

Description

Added references to asynchronous functions, changed description of video series and added a link to the video series in the "create your own skill" section. Basically worked on issue #437

Fixes #437

Status

READY

Type of change

  • Documentation (fix or adds documentation)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Mar 2, 2018

Codecov Report

Merging #478 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #478   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          18      18           
  Lines        1092    1092           
======================================
  Hits         1091    1091           
  Misses          1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e2220...8ef91d9. Read the comment docs.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

Please remove the reference to @asyncio.coroutine as it has been replaced by async def. We do not need to mention the old way of doing things.

@TarunRKaushik
Copy link
Contributor Author

will do

@jacobtomlinson
Copy link
Member

That's great! Also can you mention the await keyword too as it's important when responding to messages.

@TarunRKaushik
Copy link
Contributor Author

done. anything else?

@jacobtomlinson jacobtomlinson changed the title Worked on issue #437 Add asyncio docs and extend YouTube video text Mar 5, 2018
@jacobtomlinson
Copy link
Member

Nope this looks good, I'll merge it now.

@jacobtomlinson jacobtomlinson merged commit a48578e into opsdroid:master Mar 5, 2018
@jacobtomlinson
Copy link
Member

Ping me your address via DM on Twitter or Gitter and I'll post you some opsdroid stickers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants