-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch slack library from slacker-asyncio to aioslacker #597
Switch slack library from slacker-asyncio to aioslacker #597
Conversation
To be fair our slack connector just needs to get and deliver messages from a slack channel (since we aren't supporting other types of message yet) so I think the fact that aioslacker lib is using an older version os slacker might not pose too much of an issue. I also haven't received any answer on the issue that I created from the creator of slacker-asyncio so I'm not sure if this lib is actually being maintained actively. For what you said about the benefits of aioslacker seems like a good way for us to mitigate the issue with the dependency hell issue and if @Cadair had problems with slacker-asyncio overwriting slacker I'm sure someone else will have the same issue in the future. Basically, this is a big text to say that I might be a good idea to change from slacker-asyncio to aioslacker 👍 |
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 20 20
Lines 1369 1369
=====================================
Hits 1369 1369
Continue to review full report at Codecov.
|
Should we merge this and see how everything works or would you like me to give some quick testing on my end? |
I want to do a bit of manual testing. Feel free to do some too. Don't worry, I just try and do things when I can. |
👍 This looks like it would solve my issue with the namespace overwriting. Other than that I don't use opsdroid with slack apart from one project (and then I am using slacker directly) so I can't be much help testing. :) |
Given all the problems we've had with slacker-asyncio I thought I'd try out aioslacker instead.
The main benefits are:
Main drawbacks are:
Would be interested in thoughts from @FabioRosado and @Cadair