Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to Dockerfile and requirements.txt #635

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

aimananees
Copy link
Contributor

Description

I have worked on updating the docker image to newer python version 3.6. An addition of multidict in requirements.txt was required for successful building of the image.

Fixes #616

Status

READY

Type of change

  • This change is updating the docker image to new python version(3.6).

How Has This Been Tested?

  • Successfully built the docker image.
  • Ran the docker image and was able to execute simple instructions such as "hello", etc.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #635   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines        1381   1381           
=====================================
  Hits         1381   1381

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d40b232...3afd903. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aimananees sorry for the late answer to the PR. Why was multidict added to the PR? Is it something we need to upgrade docker?

@aimananees
Copy link
Contributor Author

Hi @FabioRosado!
While I was trying to build the docker image, I was getting the following error:
Command "/usr/local/bin/python -u -c "import setuptools, tokenize;file='/tmp/pip-install-bk0tb4l6/multidict/setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record /tmp/pip-record-ll9mdz1k/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-install-bk0tb4l6/multidict/
The command '/bin/sh -c pip3 install --no-cache-dir .' returned a non-zero code: 1

I was able to debug this error by adding multidict in requirements.txt

@FabioRosado
Copy link
Member

Ah sorry I should have read the issue and I would know why haha been awake since 3 am sorry for this.

All checks have passed and I was reading about the multidict and it seems its one dependency of aiohttp (I think the newer versions tho?). I will merge this changes now, thank you so much for working on this.

We give stickers to new contributors, if you would like one please send your address to opsdroid on twitter 👍

@FabioRosado FabioRosado merged commit 7fc97d7 into opsdroid:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docker image to newer python version
2 participants