Move the sqlite database module into core #671

[vshelke]

Description

Includes moving of sqlite database module into the core of opsdroid project.

Fixes #671

Status

READY

Type of change

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update
• Documentation (fix or adds documentation)

How Has This Been Tested?

• sqlite connection test
• sqlite put and get test

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[FabioRosado]

Thank you so much for working on this. I updated your branch in order to get the tests to run and see if everything is okay - I will have further feedback once the tests are completed.

But I got a few suggestions in regards to your work.

Note: You might need to update your local branch before you are able to push changes back into this PR.

[vshelke]

Hi @FabioRosado all tests are passed in my local for the given updated PR. But, in Travis it gives sqlite3.OperationalError: unable to open database file.
Do appdirs work differently in Travis environment ?

[FabioRosado]

Thank you so much for these changes, things are looking great!

Unfortunately travis is complaining as the tests failed, can you have a look and try to fix them?
Coverage will also complain as it will drop the overall coverage to 90%, these are the lines that are not being covered by the tests:

opsdroid/database/sqlite/__init__.py      58     22    62%   61-66, 80-86, 101-110, 151-153, 182-184

[jacobtomlinson]

I don't think appdirs should behave differently. Perhaps this is because the database exists locally for you but not in Travis?

[vshelke]

Yes @jacobtomlinson .
So i checked by deleting my sqlite.db file locally the test environment makes a new sqlite.db and runs the tests successfully.
I am wondering why travis does not create the sqlite.db file in user_data_dir on running the tests ?

[jacobtomlinson]

Perhaps the user_data_dir also doesn't exist on Travis?

[vshelke]

So how should we get the travis build passed without the user_data_dir ?
Do i have to keep the sqlite.db file in current directory at the time of build ?

[jacobtomlinson]

I think you just need to create it as part of the test setup.

[codecov]

Codecov Report

Merging #679 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #679   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     24    +1     
  Lines        1460   1521   +61     
=====================================
+ Hits         1460   1521   +61

Impacted Files	Coverage Δ
opsdroid/database/sqlite/__init__.py	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d3a9e...9d4a6aa. Read the comment docs.

[jacobtomlinson]

This is looking great. There are just a few lines which aren't being tested. If you could add a few more tests to cover everything that would be great.

[vshelke]

Hi @jacobtomlinson the tests are now complete.

[FabioRosado]

Thank you so much for the time working on this, I will merge it now 👍
We give stickers for contributors, send your home address by DM to opsdroid twitter and we will send some to you 😄