Move Telegram connector into core #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 24 25 +1
Lines 1577 1646 +69
=====================================
+ Hits 1577 1646 +69
Continue to review full report at Codecov.
|
|
Hows this going? |
|
Hey Jacob this is ready for a review whenever you have time 👍 |
jacobtomlinson
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today I spend most of the day dealing with Rocket.Chat, but since I'm waiting for some guidance in regards to the listen method I started moving the Telegram connector into the core.
There were a few things that needed to be refactored in the code and some other things had to be moved around due to linting issues. I tested the connector with telegram and everything worked as expected.
All the tests pass on my machine, but the coverage is around 80% since I commented out the
test_listen_loopuntil I figure out how to test this method when using a while loop.Fixes #665
Status
READY |
UNDER DEVELOPMENT|ON HOLDType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: