Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google-style docstrings (issue #532). #693

Merged
merged 2 commits into from
Oct 6, 2018

Conversation

tonyskapunk
Copy link
Contributor

Description

Starting with an easy one and moving along as soon as I get some feedback. Thanks!

Status

READY

Type of change

  • Documentation (fix or adds documentation)

How Has This Been Tested?

Validate the docstrings through pydoc: https://gist.github.com/tonyskapunk/0440271eed357fdd31befd476f017691

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #693 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #693   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines        1460   1460           
=====================================
  Hits         1460   1460
Impacted Files Coverage Δ
opsdroid/memory.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88405ba...18c4a87. Read the comment docs.

@jacobtomlinson
Copy link
Member

This is awesome many thanks!

@jacobtomlinson
Copy link
Member

Ping me your address via DM on Twitter or Gitter and I'll post you some opsdroid stickers!

@jacobtomlinson jacobtomlinson merged commit 16d3a9e into opsdroid:master Oct 6, 2018
@tonyskapunk tonyskapunk deleted the issue532_memory branch October 8, 2018 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Google Style Docstrings
2 participants