Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reactions to slack connector #742

Merged
merged 1 commit into from
Nov 18, 2018

Conversation

jacobtomlinson
Copy link
Member

@jacobtomlinson jacobtomlinson commented Nov 18, 2018

Description

The slack connector doesn't support the react method yet. This PR adds that functionality.

Status

READY

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually tested with Slack and this skill gist.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Nov 18, 2018

Codecov Report

Merging #742 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #742   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          27     27           
  Lines        1793   1804   +11     
=====================================
+ Hits         1793   1804   +11
Impacted Files Coverage Δ
opsdroid/connector/slack/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f52ef...87e67ca. Read the comment docs.

@FabioRosado
Copy link
Member

Looks good to me 👍

@FabioRosado FabioRosado merged commit e1f004e into opsdroid:master Nov 18, 2018
@jacobtomlinson jacobtomlinson deleted the slack-reactions branch November 18, 2018 11:37
FabioRosado pushed a commit to FabioRosado/opsdroid that referenced this pull request Nov 18, 2018
FabioRosado pushed a commit to FabioRosado/opsdroid that referenced this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants