Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #752

Merged
merged 4 commits into from
Nov 23, 2018
Merged

Refactoring tests #752

merged 4 commits into from
Nov 23, 2018

Conversation

varadgunjal
Copy link
Contributor

Description

Refactoring tests to use self.assertLogs

Fixes #748

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran Tox tests locally. All passing.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #752   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines        1843   1843           
=====================================
  Hits         1843   1843

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cb1632...c220c13. Read the comment docs.

Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some great work, thank you for working on this issue 😄 👍

@FabioRosado FabioRosado merged commit dc55b9d into opsdroid:master Nov 23, 2018
@jacobtomlinson
Copy link
Member

Ping me your address via DM on Twitter or Gitter and I'll post you some opsdroid stickers!

FabioRosado pushed a commit to FabioRosado/opsdroid that referenced this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Tests: Replace logmock with self.assertLogs
3 participants