Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self from disconnect() method when unload is called #775

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

FabioRosado
Copy link
Member

Description

I was a bit excited with merging #749 into opsdroid. I was updating the connectors and see if the shell connector was working as expected with the changes and noticed that opsdroid would hang on ctrl+c because the unload method was calling disconnect on connectors and db with self as a param.

This PR fixes those two disconnect methods and makes it possible to terminate opsdroid properly.

Fixes #

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Tox - all green
  • Started opsdroid, killed it, exited successfully.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #775 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #775   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines        1850   1850           
=====================================
  Hits         1850   1850
Impacted Files Coverage Δ
opsdroid/core.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2a079...d3c8aef. Read the comment docs.

@FabioRosado FabioRosado merged commit 6ec7b9f into opsdroid:master Dec 3, 2018
@FabioRosado FabioRosado deleted the fix-disconnect branch December 3, 2018 22:56
FabioRosado added a commit to FabioRosado/opsdroid that referenced this pull request Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant