Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update database connectors default configuration #788

Merged
merged 5 commits into from
Dec 19, 2018
Merged

Update database connectors default configuration #788

merged 5 commits into from
Dec 19, 2018

Conversation

AndresCidoncha
Copy link
Contributor

Description

  • Updated mongodb database connector example in the default config
  • Updated sqlite database connector example in the default config
  • Removed trailing spaces

Status

READY

Type of change

  • Documentation (fix or adds documentation)

How Has This Been Tested?

  1. Change configuration/example_configuration.yaml.
  2. Build the docker image.
  3. Run docker image without custom configuration.
  4. Enter in the container with docker exec -it container_name sh
  5. Execute opsdroid -e and review the loaded configuration.

Checklist:

  • I have performed a self-review of my own code

@AndresCidoncha
Update README with new path
641e3e6 
Change /etc/opsdroid reference to /root/.config/opsdroid.
@AndresCidoncha
Add docker service option
c8544dd 
Use docker service as another deployment option.
Use docker config for configuration.yaml.
@AndresCidoncha
jacobtomlinson suggested changes
a216e8d 
* Map folder instead of file to keep changes
* Removed `ro` option, folder must be writeable
* Update docker service with a docker volume option too
@AndresCidoncha
Update mongo and sqlite default examples
14c01f6
@AndresCidoncha
Merge remote-tracking branch 'upstream/master'
47c07ad
@codecov
Copy link

codecov bot commented Dec 19, 2018 •
edited
Loading

Codecov Report

Merging #788 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #788   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          28     28           
  Lines        1851   1851           
=====================================
  Hits         1851   1851

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4cb0cb...47c07ad. Read the comment docs.

FabioRosado
FabioRosado approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@FabioRosado FabioRosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this Andres, I remember being puzzled by the databases configuration reference when trying the sql one, great that you updated it 😄 👍

@FabioRosado FabioRosado merged commit ea1ed8a into opsdroid:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabioRosado FabioRosado FabioRosado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndresCidoncha @FabioRosado