Support custom webhook response #793
Conversation
Codecov Report
@@ Coverage Diff @@
## master #793 +/- ##
==========================================
- Coverage 100% 99.94% -0.06%
==========================================
Files 29 29
Lines 1901 1903 +2
==========================================
+ Hits 1901 1902 +1
- Misses 0 1 +1
Continue to review full report at Codecov.
|
|
Awesome! This is really useful, thanks for raising this. Please go ahead with tests and documentation. |
|
OK. I'll do it. |
|
I've gone ahead and added the tests and docs, I totally understand that things sometimes get in the way of updating a PR you've raised. It has now been merged in #807 so I'm going to close this PR. Thanks for your help! Ping me your address via DM on Twitter or Gitter and I'll post you some opsdroid stickers! |
* Make it possible to create class-based skills * Rework based on requests in the PR * Add deprecation warnings if a function based skill is loaded * Update documentation with the details of the class based skills * Add pylint exception and remark about a broad except in skill.py * Add tests for the Skill base class * wip: Add tests for the class-based skill loader * WIP: Add tests for the class based skills * Update pytest-cov from 2.6.0 to 2.6.1 (#799) * Update pillow from 5.3.0 to 5.4.1 (#797) * Update pytest from 4.0.2 to 4.1.0 (#798) * Update arrow from 0.12.1 to 0.13.0 (#800) * Update recommonmark from 0.4.0 to 0.5.0 (#802) * Update aiohttp from 3.5.1 to 3.5.2 (#801) * Update aiohttp from 3.5.2 to 3.5.3 (#804) * Bump Pyyaml to avoid CVE-2017-18342 (#803) * Bump Pyyaml to avoid CVE-2017-18342 * Add SafeLoader to yaml.load * Add test for fix * Update aiohttp from 3.5.3 to 3.5.4 (#805) * Support custom webhook response (replacement for #793) (#807) * Support custom webhook response * Add tests for custom webhook response * Add docs for custom webhook response * Fix linting issues * Fix broken test * Add tests for class skills * Update all documentation to use new class based skills * Update class name
|
Nice work! sorry for my procratinating. |
Description
sometimes, we need to respond a custom json or text to the webhook caller.
let me know what do you think about this. I'll add or run testcase later.
Status
UNDER DEVELOPMENT
Type of change
Checklist: