Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now ignoring pipenv files #846

Merged
merged 1 commit into from Feb 15, 2019
Merged

Now ignoring pipenv files #846

merged 1 commit into from Feb 15, 2019

Conversation

alexmarginean16
Copy link
Contributor

Description

I updated the .gitignore file to be able to ignore the files created by pipenv.

Fixes #843

Status

READY

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • I cloned my fork, created a virtualenv, then installed pipenv pip install pipenv, then initialized it pipenv install. After that the file was created and if I type git status I get:

      On branch master
      Your branch is up to date with 'origin/master'.
    
      nothing to commit, working tree clean
    

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@FabioRosado
Copy link
Member

👋 Hello @alexmarginean16 thank you so much for working on this issue!
As soon as travis and the rest is green I will merge this PR - I will be happy to see my pipfiles ignored soon 😄

We have a few other issues currently open, let me know if you need help starting any of them if you are interested!

We also send opsdroid stickers to new contributors, send your home address through DM to opsdroid

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #846   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines        2070   2070           
=====================================
  Hits         2070   2070

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d55bfc...dbd0cb3. Read the comment docs.

@FabioRosado FabioRosado merged commit bee09f4 into opsdroid:master Feb 15, 2019
@alexmarginean16
Copy link
Contributor Author

Thanks a lot! I will definitely take a look at other issues 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pipfile and pipfile.lock to .gitignore
2 participants