Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram Connector: Parse edited messages as if new message #866

Merged

Conversation

FabioRosado
Copy link
Member

Description

I have decided to just implement @iobreaker easiest solution to the edited_message issue. I have tested the connector with an edited message and as reported everything worked fine 馃憤

The test added was meant to keep coverage to 100% when I ran the test to see if opsdroid.parse was called it would always return False - maybe I have to call parse twice but I'm not entirely sure 馃

Fixes #862

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Tox - all green
  • Ran opsdroid with the fix, edited message, opsdroid parsed newly edited message.

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #866   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines        2115   2117    +2     
=====================================
+ Hits         2115   2117    +2
Impacted Files Coverage 螖
opsdroid/connector/telegram/__init__.py 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 285d6df...c4aa884. Read the comment docs.

@jacobtomlinson
Copy link
Member

Nice stuff. I like the code to test ratio in this PR 馃槅.

@jacobtomlinson jacobtomlinson merged commit 2a122ae into opsdroid:master Mar 7, 2019
@FabioRosado FabioRosado deleted the telegram-edited-message branch March 7, 2019 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telegram Connector : Parsing edited message cause process to freeze
2 participants