Fixing websocket Message parsing error #867

[iobreaker]

Description

This fix is for issue #867 with Message Parameters order in websocket connector and for the exception raised when testing if message.text is not empty when message object is None in core.py

Fixes #867

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Test fixed and added

How Has This Been Tested?

• Manually with opsdroid-desktop (all good)

Testing Logs

INFO opsdroid.web: Started web server on http://127.0.0.1:8080
INFO aiohttp.access: 127.0.0.1 [07/Mar/2019:21:23:40 +0000] "POST /connector/websocket HTTP/1.1" 200 220 "-" "-"
DEBUG opsdroid.connector.websocket: User connected to 474c9c84-411f-11e9-a552-b8e85642f7e8
<opsdroid.connector.websocket.ConnectorWebsocket object at 0x10311b940>
DEBUG opsdroid.core: Parsing input: hi
DEBUG opsdroid.core: Processing parsers...
DEBUG opsdroid.connector.websocket: Responding with: 'Hi None' in target 474c9c84-411f-11e9-a552-b8e85642f7e8

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation (if applicable)
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[codecov]

Codecov Report

Merging #868 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #868   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines        2187   2188    +1     
=====================================
+ Hits         2187   2188    +1

Impacted Files	Coverage Δ
opsdroid/connector/websocket/__init__.py	100% <100%> (ø)	⬆️
opsdroid/core.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dfa6c4...2a3ffeb. Read the comment docs.

[iobreaker]

usually sending an empty message is avoided by the chat client but in case of opsdroid-desktop the empty message is sent to opsdroid. I did the modification to ignore empty message as it was before the modification (spiting test in two steps).

[jacobtomlinson]

Many thanks! Don't forget to ping me your address via DM on Twitter or Gitter and I'll post you some opsdroid stickers!