Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Messages before Parsing #913

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

mugoh
Copy link
Contributor

@mugoh mugoh commented Apr 26, 2019

Description

The matrix connector attempts to parse empty messages. This issue is solved by checking the message has a value before calling the parsing function.

Fixes #905

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tox tests pass locally

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #913 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #913   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines        2198   2198           
=====================================
  Hits         2198   2198
Impacted Files Coverage Δ
opsdroid/connector/matrix/connector.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab9d65...9c5e999. Read the comment docs.

@FabioRosado
Copy link
Member

Thank you so much for working on this issue @hogum I am going to merge this PR now.
We send opsdroid stickers to new contributors so if you would like yours send a DM with your address to opsdroid twitter and we will send you some 😄 👍

@FabioRosado FabioRosado merged commit cc2e071 into opsdroid:master Apr 26, 2019
@mugoh
Copy link
Contributor Author

mugoh commented Apr 26, 2019

Thank you for the warm welcome @FabioRosado 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matrix connector tries to parse empty messages
3 participants