Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Image support for Telegram #929

Merged
merged 4 commits into from
May 13, 2019

Conversation

FabioRosado
Copy link
Member

@FabioRosado FabioRosado commented May 10, 2019

Description

This is a work in progress. I am raising this PR because I need help with the tests. I spent the whole day trying to go around with it but I couldn't figure out how to go around it.

I am going to try and work on the other connectors after I figure out how to test the telegram connector properly since most other connectors use the API to get and send messages I might have to reuse this code elsewhere.

Status

READY | UNDER DEVELOPMENT | ON HOLD

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Travis - all green
  • Send image to telegram - worked as expected

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@FabioRosado FabioRosado marked this pull request as ready for review May 11, 2019 14:47
@FabioRosado FabioRosado reopened this May 11, 2019
@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #929 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #929   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          37     37           
  Lines        2338   2346    +8     
=====================================
+ Hits         2338   2346    +8
Impacted Files Coverage Δ
opsdroid/connector/telegram/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c442858...6872ec4. Read the comment docs.

@jacobtomlinson
Copy link
Member

Thanks for this looks good!

@jacobtomlinson jacobtomlinson merged commit d1d2592 into opsdroid:master May 13, 2019
@FabioRosado FabioRosado deleted the add-image-support branch November 18, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants