Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex and parse_format matchers #940

Merged
merged 7 commits into from
May 15, 2019
Merged

Conversation

Cadair
Copy link
Contributor

@Cadair Cadair commented May 15, 2019

Description

This fixes a regression in 0.15.

I decided to apply both the fixes, I can revert one or the other if people want.

Fixes #934

Status

READY

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

unit tests

Checklist:

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #940 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #940   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          37     37           
  Lines        2346   2342    -4     
=====================================
- Hits         2346   2342    -4
Impacted Files Coverage Δ
opsdroid/core.py 100% <ø> (ø) ⬆️
opsdroid/parsers/regex.py 100% <100%> (ø) ⬆️
opsdroid/parsers/parseformat.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e95f6...eb65cb6. Read the comment docs.

@FabioRosado
Copy link
Member

I have tested these changes with my skill that generates images and uses regex group to get the details passed to opsdroid and everything worked fine 👍

@FabioRosado FabioRosado merged commit 01ec646 into opsdroid:master May 15, 2019
@Cadair Cadair deleted the fix_regex branch May 15, 2019 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex.group broke after events got merged into core
3 participants