Sink `Close()` method is never called #10

mdemierre · 2019-12-15T13:09:21Z

Whie implementing a new sink, I noticed that my Close() method was never called.

I expected it to be called when sending SIGTERM to the process, and that it would be waited for before terminating.

The text was updated successfully, but these errors were encountered:

Before the change, the engine didn't call the `Close()` method of the sinks. This is needed in some cases, i.e when a sink implementation is buffered. This change adds a `Close()` method to the registry that will signal sinks to exit and wait for all sinks to exit before returning. In the channel-based registry, the closing of all sinks is done in parallel (using a `sync.WaitGroup`). In the sync registry, sinks are closed one after the other. Fixes issue opsgenie#10

Before the change, the engine didn't call the `Close()` method of the sinks. This is needed in some cases, i.e when a sink implementation is buffered. This change adds a `Close()` method to the registry that will signal sinks to exit and wait for all sinks to exit before returning. This is then used in the engine stop logic. In the channel-based registry, the closing of all sinks is done in parallel (using a `sync.WaitGroup`). In the sync registry, sinks are closed sequentially. Fixes issue opsgenie#10

mdemierre mentioned this issue Dec 15, 2019

engine: Implement clean closing of sinks #11

Merged

mustafaakin closed this as completed Dec 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sink `Close()` method is never called #10

Sink `Close()` method is never called #10

mdemierre commented Dec 15, 2019

Sink Close() method is never called #10

Sink Close() method is never called #10

Comments

mdemierre commented Dec 15, 2019

Sink `Close()` method is never called #10

Sink `Close()` method is never called #10