#11 Use tempfile to generate and clean up a writable directory #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @5nafu, can you rebase your branch? |
|
Hi @5nafu, you can track the progress about the issue from this ticket |
ahalac-atlassian
force-pushed
the
use_tempfile
branch
from
0b14e9f
to
a5dd8af
Compare
|
This PR somewhat breaks the Icinga2 scripts on older OS releases with older python versions where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #11 by creating a temporary directory for each run and cleaning up after the perf_data was uploaded.