-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove special characters for zabbix send2opsgenie.go #82
Conversation
Can I ask why? The alert on Zabbix is "/dir1/dir2 : Disk space is low (used > 80%)" and becomes : "dir1dir2 Disk space is low used 80" on Opsgenie. We have alerts for directory monitoring and the removal of special characters makes it difficult to read. Did you encounter any problems with sending special characters? I've edited the send2opsgenie.go and removed the "removeSpecialCharacters" to test it. Edit: it works fine after recompiling, so what is the reason removing them ? |
Why was this done? 🥲 |
This change makes for incredibly confusing alert messages: @cglrkn @MeralBusraTekinsen can you consider reverting this change? |
I recompiled send2opsgenie.go myself as well to fix this issue. Not impressed with how unresponsive Atlassian is with some long standing open issues with this product. |
@cglrkn @MeralBusraTekinsen Why did you remove special characters? Many of my trigger that contained URLs are broken after update the plugin to latest version. Is threre a valid reason for this? It is possibile to bypass this? |
@hamadodene since it’s clear that they aren’t responsive here, you should probably open a support ticket. I would recommend editing the source code as a workaround. It’s working stable for me. |
Thanks @mcbrineellis i will try to edit source code. I am still trying to understand the purpose of this modification. At least providing a motivation in the pull request description would have been helpful. |
Totally agree... there was no reasoning provided. To me it makes no sense why special characters would be stripped in this case, as it's normal for a trigger name, description, host group to have those. Stripping them makes the alert or description unreadable. |
Looks like there's an issue open for it on their JIRA: https://jira.atlassian.com/browse/OPSGENIE-1090 I just voted for it. If you do open a support case maybe you can reference that issue. |
No description provided.