Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing numpy dependency #43

Merged
merged 6 commits into from Jan 25, 2021
Merged

Removing numpy dependency #43

merged 6 commits into from Jan 25, 2021

Conversation

yaleman
Copy link
Contributor

@yaleman yaleman commented Dec 7, 2020

Numpy's a very heavy dependency for a number type check, this removes it and uses the features in six.

@yaleman yaleman mentioned this pull request Dec 7, 2020
@BartlomiejSkwira
Copy link

Can we get this merged and released? numpy shouldn't be part of this lib
@mhamzak008 @alpgurtan @kaanbasal

@mhamzak008 mhamzak008 merged commit 8e3f786 into opsgenie:master Jan 25, 2021
@BartlomiejSkwira
Copy link

@mhamzak008 Thank you! 👍

@BartlomiejSkwira
Copy link

BartlomiejSkwira commented Jan 26, 2021

Will you also be updating the version in PyPI? https://pypi.org/project/opsgenie-sdk/ the last one available is 2.0.3 Released: Jan 24, 2020

@mhamzak008
Copy link
Contributor

No problem, and yes we will do that soon as well

@BartlomiejSkwira
Copy link

@mhamzak008 You also need to update VERSION to 2.1.1 in setup.py for the new release

@mhamzak008
Copy link
Contributor

Yes that's my bad. I will fix it. Thanks for pointing it out @BartlomiejSkwira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants