Fix drift for empty time_restriction #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjacquet
force-pushed
the
time-restriction-fix
branch
from
847efd3
to
56c8e2b
Compare
|
Highly appreciate this pull request 🙏🏼 |
|
LGTM, thank you @gjacquet |
koushik-swaminathan
approved these changes
Nov 15, 2023
|
Thanks @koushik-swaminathan for the review. Is there something missing to get this merged? |
|
Hi @axdotl, I will be merging it today :) |
|
Hello @koushik-swaminathan, when are you planning the next release to include this fix ? |
|
Hi @koushik-swaminathan, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix drift when time_restriction block is not defined.
Fixes #412.