This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
UI: retry login POST request to /_/auth/session #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to enhance robustness, allowing for auto-healing short transient issues -- motivated in particular by CI instability #1249. The retrying config around this request in particular will always be rather unique and so it makes sense to keep the parameters very local to where the request is performed. Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
It's fine and even better to re-throw this error so that it's fully captured for debuggability in both, console and Sentry. Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
|
All three CI jobs have passed the critical stage -- login flow succeeded. Merging early, opening next PR based on this any minute. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enhance robustness, allowing for auto-healing short transient issues. Also motivated by CI instability #1249.