This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
ci: push/pull CI container image. #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgehrcke
force-pushed
the
jp/ci-push-pull-containerimage
branch
from
a63930c
to
0e84764
Compare
So far the CI container image was never pushed to docker hub. It was bound to the lifetime of the VM (or disk). Can probably reduce the preamble duration of some builds that start from a rather new state by using image layers stored on docker hub. Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
could push the image from within that container. in preamble. as bg process. could cut a minute? keep in mind as optimization. Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
for making browser display content in tab right away instead of offering download Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
jgehrcke
force-pushed
the
jp/ci-push-pull-containerimage
branch
from
93b2eee
to
fbad924
Compare
|
Hm. Docker credentials are set up in Knowing that this works from within the CI container I will now move the push of the current CI container image into said container. |
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
needed in the looker build steps below, not done in bg w/ unique build dir Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
The CLI build has some implicit surprising dependency on the controller. While building the CLI tsc complains that [2021-08-16T19:12:22Z] ../controller/src/dbSDK.ts(17,31): error TS2307: Cannot find module 'graphql-request' or its corresponding type declarations.../controller/src/dbSDK.ts The CLI build should not trigger a (partial) controller build. As per the dependencies, the CLI depends on controller-config but not on .. well. Signed-off-by: Dr. Jan-Philip Gehrcke <jp@opstrace.com>
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far the CI container image was never pushed to docker hub.
It was bound to the lifetime of the VM / disk.
Sometimes, a build finds empty / fresh state (fresh disk) and then the CI container image needs to be built from scratch. This takes a few minutes. Can reduce the duration of that process by pulling in some image layers stored on docker hub. (the last N layers need to be built and pushed for each build, and that's at the con side of this change -- let's monitor the impact).