This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
cli(destroy): handle gcp global address tear down #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simão Reis <sreis@opstrace.com>
Workaround for #976 to avoid hitting an undocumented API limitation where a second request to delete a global address is returning a 400. Signed-off-by: Simão Reis <sreis@opstrace.com>
jgehrcke
reviewed
Aug 24, 2021
| yield call(deleteAddress, { | ||
| name: addressName | ||
| }); | ||
| deleteIssued = true; |
There was a problem hiding this comment.
ok! :)
For future: another option is to issue the DELETE API call in a loop, i.e. potentially more than once and catch-log all resulting API errors (getting said 400 response is absolutely fine -- we just crashed too much). And to then have a definite 'desired state reached' criterion for leaving said loop.
That's the paradigm we have implemented for most of AWS resource deletion via
opstrace/lib/aws/src/resource.ts
Line 148 in ebd5c98
opstrace/lib/aws/src/resource.ts
Line 269 in ebd5c98
jgehrcke
reviewed
Aug 24, 2021
| if [ "${EXITCODE_DESTROY}" -ne 0 ]; then | ||
| echo "teardown() not yet finished, destroy failed. Exit with exitcode of destroy" | ||
| exit "${EXITCODE_DESTROY}" | ||
| fi |
|
Looks like it worked, it only issued one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #976. I think this is some undocumented behavior where a second request to delete the global address returns a 400.
The log output of a successful destroy operation shows the global desired state is reached immediately after the delete.
A failed run shows it tried to issue a delete twice.
This was not caught earlier in the upgrade tests because the teardown script was swallowing the error. This is also fixed in this PR.