This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
fix(users): add-user error handling #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoSattler
force-pushed
the
mosattler/error-handling-int-stuff
branch
from
5c816a3
to
9920100
Compare
Signed-off-by: Mo Sattler <hi@mosattler.com>
MoSattler
force-pushed
the
mosattler/error-handling-int-stuff
branch
from
9920100
to
62fc6a4
Compare
MoSattler
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, on the user page, when one clicked "Add User", and then did either not add an email as a name, or no name at all, the user creation would fall silently without any feedback to the user.
This PR adds a banner for these cases, to inform that a user was not created in these cases, and the reason why.
While this is an improvement over the current situation, ideally we want proper form validation, and prevent submission of the form.
I am not sure, if this is possible with the way this currently works (using the Dialog), though.
Have you...