Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve perf error handling #10

Merged
merged 3 commits into from
Feb 26, 2019
Merged

perf: improve perf error handling #10

merged 3 commits into from
Feb 26, 2019

Conversation

ilyar
Copy link
Contributor

@ilyar ilyar commented Feb 21, 2019

#8 #6

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #10 into master will increase coverage by 6.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   84.03%   90.32%   +6.28%     
==========================================
  Files           6        6              
  Lines         119      124       +5     
==========================================
+ Hits          100      112      +12     
+ Misses         17       11       -6     
+ Partials        2        1       -1
Impacted Files Coverage Δ
api/routers.go 100% <ø> (ø) ⬆️
cmd/document/pdf.go 95.12% <100%> (ø) ⬆️
cmd/template/template.go 100% <100%> (+24.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84282f4...8b8d8da. Read the comment docs.

@ilyar ilyar merged commit 9ef3405 into master Feb 26, 2019
@ilyar ilyar deleted the improve-handling-error branch February 26, 2019 20:54
@ilyar ilyar added this to Done in v1.0.0 Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v1.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant