Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ Upgrade from 1.2.11 to 1.4.0 (bye bye Java 8) #131

Closed
1 of 3 tasks
adriens opened this issue Aug 29, 2022 · 5 comments
Closed
1 of 3 tasks

⬆️ Upgrade from 1.2.11 to 1.4.0 (bye bye Java 8) #131

adriens opened this issue Aug 29, 2022 · 5 comments
Assignees
@Dougniel
Labels
released RUN wontfix This will not be worked on

Comments

@adriens
Copy link
Member

adriens commented Aug 29, 2022 •
edited by Dougniel
Loading

❔ Contexte

Une nouvelle version logack est sortie mais qui implique des breaking changes.

🎯 Objectif

Le but est ici de remettre la lib sur les rails pour permettre des upgrades glissants.

✔️ Actions
@adriens adriens pinned this issue Aug 29, 2022
mbarre added a commit that referenced this issue Oct 3, 2022
@mbarre
feat(java): upgrade to java 11
4d800c5 
refs: #131
@adriens adriens assigned Dougniel and unassigned mbarre Oct 12, 2022
Dougniel added a commit that referenced this issue Oct 20, 2022
@Dougniel
refactor: Plus de support java 8
a857455 
BREAKING CHANGE: Plus de compatibilité Java 8

Fixes #131
@Dougniel
Copy link
Member

Dougniel commented Oct 20, 2022 •
edited
Loading

@adriens, @mbarre voici sur quoi je suis tombé : on embarque les dépendances JUnit dans les applications utilisants opt-logging 💩

image

Ah et c'est en public 😅

@Dougniel Dougniel mentioned this issue Oct 20, 2022
Closed
@Dougniel
Copy link
Member

@adriens, en regardant de plus près ce sac de noeuds, il semble que la version Logback 1.4.x soit incompatible avec la dernière version de Spring Boot 2.7.4 qui se base sur Logback 1.2.x (ils tirent une dépendance en commun d'une version incompatible qui cause le java.lang.ClassNotFoundException: org.slf4j.impl.StaticLoggerBinder car le groupId de log4j a changé au passage)

👉🏼Dans l'état actuel (lib pour Spring boot), on est trop en avance par rapport à Spring Boot donc cette évolution n'a pas de sens

@Dougniel Dougniel added the wontfix This will not be worked on label Oct 20, 2022
Dougniel added a commit that referenced this issue Oct 20, 2022
@Dougniel
Revert "feat(java): upgrade to java 11"
96745a0 
This reverts commit 4d800c5.

#131
@Dougniel Dougniel mentioned this issue Oct 20, 2022
Merged
github-actions bot pushed a commit that referenced this issue Oct 20, 2022
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
3dae01e 
# [3.0.0](v2.1.24...v3.0.0) (2022-10-20)

### Bug Fixes

* bump junit-jupiter.version from 5.9.0 to 5.9.1 ([3b64ac4](3b64ac4))
* bump spring-boot-starter-test from 2.7.3 to 2.7.4 ([f17784e](f17784e))
* bump spring-context from 5.3.22 to 5.3.23 ([967543c](967543c))
* **deps:** Suppression des dépendances transitives JUnit  💩 ([faf9f96](faf9f96)), closes [#139](#139)
* **deps:** Suppression des dépendances transitives JUnit  💩 ([916efc2](916efc2)), closes [#139](#139)

### Code Refactoring

* Plus de support java 8 ([a857455](a857455)), closes [#131](#131)

### BREAKING CHANGES

* Plus de compatibilité Java 8
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@adriens
Copy link
Member Author

adriens commented Oct 20, 2022

💪 🙏

@Dougniel
Copy link
Member

💪 🙏

@adriens, tu as bien lu mon commentaire ? Semantic-release a passé bêtement ce ticket à released mais en fait je l'ai mis en won't fix

@Dougniel Dougniel mentioned this issue Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dougniel Dougniel

Labels
released RUN wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

bye-bye-java-8 opt-nc/opt-logging
3 participants
@mbarre @adriens @Dougniel