-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt sbt-typelevel-ci-release #1307
Adopt sbt-typelevel-ci-release #1307
Conversation
@deprecated("Preserved for bincompat", "3.2.0") | ||
class MacroAsOpsImpl(c: blackbox.Context) extends MacroOpsImpl(c) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes bincompat broken in:
@deprecated("Preserved for bincompat", "3.1.0") | ||
def index[I, A1](i: I, evIndex: Index[A, I, A1]): Optional[S, A1] = | ||
self.index(i)(evIndex, implicitly, implicitly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and similar changes fixes bincompat broken in:
@xuwei-k could I ask you to review this PR? I don't know enough about sbt. Otherwise, it looks good to me. |
@julien-truffaut how would you feel about moving ahead with this? I am happy to answer any questions and take responsibility in case you have any issues. |
Completely and I am very sorry for the delay.
Thanks a lot for your work and especially for fixing the binary
compatibility issues.
On Mon, 24 Oct 2022 at 23:42, Arman Bilge ***@***.***> wrote:
@julien-truffaut <https://github.com/julien-truffaut> how would you feel
about moving ahead with this? I am happy to answer any questions and take
responsibility in case you have any issues.
—
Reply to this email directly, view it on GitHub
<#1307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOF6WNWTMADWJASY7UUA2DWE37FNANCNFSM6AAAAAAREOLLSM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Julien Truffaut
Tel : +43 676 5758738
Tel : +44 7743 449664
|
No problem at all! The bincompat issues were easier to fix than I originally feared. Btw, auto-merge will not work because the names of the CI jobs changed (sorry about that). |
As discussed in #1301 (comment). Once this PR merges I will add Scala Native support in a follow-up PR.
Note that you have broken binary-compatibility against your previous releases, probably because you were not checking it in CI.
The easiest way to fix this is to bump your major version to 4.0 and be more vigilant going forward, since sbt-typelevel will now check this in CI.
I will investigate and can do my best to try and fix this but it can be very time-consuming. I may recommend that you revert some PRs and re-do them properly.