Cross-build for Scala Native #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
requested review from
julien-truffaut,
cquiroz and
xuwei-k
as code owners
armanbilge
commented
Oct 25, 2022
Comment on lines
-104
to
+105
| lazy val munit = Def.setting("org.scalameta" %% "munit" % "0.7.21" % Test) | ||
| lazy val munitDiscipline = Def.setting("org.typelevel" %% "discipline-munit" % "1.0.9" % Test) | ||
| lazy val munit = Def.setting("org.scalameta" %%% "munit" % "1.0.0-M6" % Test) | ||
| lazy val munitDiscipline = Def.setting("org.typelevel" %%% "discipline-munit" % "2.0.0-M3" % Test) |
There was a problem hiding this comment.
Note the missing %. Previously tests were not being run on JS at all.
Comment on lines
-81
to
-84
| implicit def uuidArbitrary: Arbitrary[UUID] = Arbitrary(UUID.randomUUID) | ||
|
|
||
| implicit def uuidCoGen: Cogen[UUID] = | ||
| Cogen[(Long, Long)].contramap[UUID]((u: UUID) => (u.getMostSignificantBits, u.getLeastSignificantBits)) |
There was a problem hiding this comment.
ScalaCheck already provides these. That implementation is preferable because:
- It respects the ScalaCheck seed so it is reproducible.
randomUUIDwas recently affected by a CVE. See GHSA-j2f9-w8wh-9ww4
julien-truffaut
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1301.