Crosscompile core to dotty #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
cquiroz
commented
Oct 22, 2020
|
|
||
| if (!snapshot && stable) { | ||
| (version in ThisBuild).value | ||
| } else { | ||
| (previousStableVersion in ThisBuild).value.get | ||
| (previousStableVersion in ThisBuild).value.getOrElse("UNKNOWN") |
There was a problem hiding this comment.
I've hit an error on my GH actions with this line. I'm not sure the getOrElse workaround is appropriate
There was a problem hiding this comment.
I don't know either, let's merge and we'll see.
julien-truffaut
approved these changes
Oct 22, 2020
|
Great work, thank you @cquiroz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to cross compile the core module to
dottyand scala2.13.3It works locally but I had some problems with the
doctask on GH actionsFixes #925