New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING CHANGES] JSZip package upgrade #107
Conversation
1. converted necessary methods to async 2. API Interface changes with this
.idea/jsLibraryMappings.xml | ||
.idea/jsLinters/jshint.xml | ||
.idea/libraries/sass_stdlib.xml | ||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps idea files above can be dropped as well.
that way it give us time to think how make less disruptive changes. Maybe we can take inspiration from https://stackoverflow.com/questions/16586640/node-js-async-to-sync and provide backward compatible API + async alternatives. |
@kant2002 let me know what would you like to do with this PR. If you want to have a v2, then have it as a separate release? or maintain it under separate branch for now and do a release later! |
@tiholic I want you to show how can we have cake and eat it too. I believe we can achieve your goals without major changes in the API and everything will just works. I will keep it for reference, but eventually likely it would not be accepted. |
bump. The release of v2 would be much appreciated, as the jszip2.6.1 has a CWE-29 vulnerability. Most likely the jszip team wont release a hotfix for a version of 2016 release date, so a shift to async API with new jszip and v2 of xlsx-template is preferred. Thanks. |
I made a fork of old JSzip for now and apply security fixes. So this is in its current form not needed. If you have idea how to expose async API so I can gradually migrate without disrupting users, I would appreciate it |
Upgraded JSZip to latest version 3.5.0 as per upgrade guide
This resulted in API changes as few methods required to be converted as async
Pre release checklist