cmake: add support for compiling bitpit with MSVC #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-iob
force-pushed
the
bitpit.msvc
branch
from
f30b28d
to
c2079c9
Compare
andrea-iob
force-pushed
the
bitpit.msvc
branch
3 times, most recently
from
5695926
to
79beaa4
Compare
Setting the CMake variable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS is not enough to properly export static members.
andrea-iob
force-pushed
the
bitpit.msvc
branch
13 times, most recently
from
cf970b0
to
08566a3
Compare
andrea-iob
force-pushed
the
bitpit.msvc
branch
2 times, most recently
from
c5c45c4
to
9659b07
Compare
andrea-iob
force-pushed
the
bitpit.msvc
branch
from
e3d4f01
to
6028c15
Compare
andrea-iob
force-pushed
the
bitpit.msvc
branch
from
dab6247
to
78c339f
Compare
|
This commit looks unrelated and it introduces changes in the API usage 057fa2d. |
It's needed because there is a windows include that defines a macro named ERROR. |
edoardolombardi
approved these changes
Feb 22, 2024
andrea-iob
force-pushed
the
bitpit.msvc
branch
from
31415fd
to
fee0803
Compare
|
I fixed a problem introduced by commit 5eb85b2. |
andrea-iob
force-pushed
the
bitpit.msvc
branch
from
fee0803
to
97e7b29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support form compiling bitpit with MSVC.