Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8984]: Updates SendOdpEvent with go-sdk latest changes. #367

Merged
merged 2 commits into from
Mar 8, 2023
Merged

[FSSDK-8984]: Updates SendOdpEvent with go-sdk latest changes. #367

merged 2 commits into from
Mar 8, 2023

Conversation

yasirfolio3
Copy link
Contributor

Summary

  • Updates SendOdpEvent to return error returned by go-sdk

Issues

  • All tests should pass.

andrewleap-optimizely
andrewleap-optimizely requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we forgot to add the 500 error to openapi.yaml, can you add it?

Mat001
Mat001 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3
Copy link
Contributor Author

Looks good. I think we forgot to add the 500 error to openapi.yaml, can you add it?

done 👍

andrewleap-optimizely
andrewleap-optimizely approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yasirfolio3 yasirfolio3 merged commit 19a79ad into master Mar 8, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/FSSDK-8984 branch March 8, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mat001 Mat001 Mat001 approved these changes

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yasirfolio3 @Mat001 @andrewleap-optimizely