Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-9632] Add helper function for notification center #381

Merged
merged 11 commits into from
Sep 19, 2023
Merged

[FSSDK-9632] Add helper function for notification center #381

merged 11 commits into from
Sep 19, 2023

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented Sep 13, 2023 •
edited

Summary

Ticket: FSSDK-9632

@pulak-opti pulak-opti marked this pull request as ready for review September 15, 2023 10:38
@pulak-opti pulak-opti requested a review from a team as a code owner September 15, 2023 10:38
mikechu-optimizely
mikechu-optimizely approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts, but otherwise, LGTM

.github/workflows/source_clear_cron.yml Outdated Show resolved Hide resolved
.github/workflows/source_clear_cron.yml Show resolved Hide resolved
pkg/client/factory_test.go Show resolved Hide resolved
pkg/config/datafileprojectconfig/mappers/condition_trees.go Show resolved Hide resolved
@pulak-opti pulak-opti merged commit c20465b into master Sep 19, 2023
15 checks passed
@pulak-opti pulak-opti deleted the pulak/add-with-nc-method branch September 19, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@pulak-opti pulak-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pulak-opti @mikechu-optimizely