Gp failed submit #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,6 +102,8 @@ def run(self): | |||
| self.__logger.info("Submitting Kubernetes Job: " + self.uu_name) | |||
| try: | |||
| run_and_track_job(self.kubernetes_client, job) | |||
| except: | |||
| logger.warning("Luigi has failed to submit the job, starting cleaning") | |||
There was a problem hiding this comment.
Don't we want to see the exception here?
There was a problem hiding this comment.
I could do, the clean function below also prints it though, didn't know if we wanted to double up?
stathischaritos
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just adds a warning message when a job fails to submit. The error is raised by the clean process but it is a little unclear in the logs that the submit failed without this message.