Call setState on React components once per dispatch #195
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current ReactMixin implementation calls `reactor.observe` separately for each entry in the response to a React component's getDataBindings. If multiple pieces of bound data change in a single dispatch, Nuclear will call setState on the component for each of them and React will dutifully render each time. This means that the exact behavior of your component is dependent on the order in which you define your data bindings (aside from being bad for performance). This patch switches to a single `reactor.observe` call that includes all of the data bindings for the component. Fixes optimizely#193
|
I'm going to close this since it hasn't gotten any attention. I'd love to see this re-opened and landed to fix #193! |
iansinnott
added a commit
to iansinnott/nuclear-js-react-addons
that referenced
this pull request
Aug 4, 2016
…onents Relates to optimizely/nuclear-js#195. For the connect method, this change adds only one observer to the reactor per call as opposed to adding a separate listener for each key returned by mapStateToProps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ReactMixin implementation calls
reactor.observeseparately for each entry in the response to a React component's getDataBindings. If multiple pieces of bound data change in a single dispatch, Nuclear will call setState on the component for each of them and React will dutifully render each time. This means that the exact behavior of your component is dependent on the order in which you define your data bindings (aside from being bad for performance).This patch switches to a single
reactor.observecall that includes all of the data bindings for the component.Fixes #193