Added more test cases for setForcedVariation.

optimizely · Jul 5, 2017 · 88af55f · 88af55f
1 parent b0aa642
commit 88af55f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Optimizely/ProjectConfig.php b/src/Optimizely/ProjectConfig.php
@@ -279,7 +279,8 @@ public function setForcedVariation($experimentKey, $userId, $variationKey)
         }
 
         $this->_preferredVariationMap[$userId] = array($experimentId => $variationId);
-        $this->_logger->log(Logger::DEBUG, sprintf('Set variation "%s" for experiment "%s" and user "%s" in the preferred variation map.', $variationId, $experimentId, $userId));     
+        $this->_logger->log(Logger::DEBUG, sprintf('Set variation "%s" for experiment "%s" and user "%s" in the preferred variation map.', $variationId, $experimentId, $userId));   
+
         return TRUE;   
     }
 

diff --git a/tests/OptimizelyTest.php b/tests/OptimizelyTest.php
@@ -1216,7 +1216,6 @@ public function testSetForcedVariation()
 
         $userAttributes = [
             'device_type' => 'iPhone',
-            'company' => 'Optimizely',
             'location' => 'San Francisco'
         ];
 
@@ -1236,5 +1235,10 @@ public function testSetForcedVariation()
         $this->assertTrue($optlyObject->setForcedVariation('test_experiment', 'test_user', 'variation'), 'Set variation to "variation" failed.');
         $forcedVariationKey = $optlyObject->getVariation('test_experiment', 'test_user', $userAttributes);
         $this->assertEquals('variation', $forcedVariationKey);
+
+        // make sure another setForcedVariation call sets a new forced variation correctly
+        $this->assertTrue($optlyObject->setForcedVariation('test_experiment', 'test_user2', 'variation'), 'Set variation to "variation" failed.');
+        $forcedVariationKey = $optlyObject->getVariation('test_experiment', 'test_user2', $userAttributes);
+        $this->assertEquals('variation', $forcedVariationKey);
     }
 }